Don't break build when a suppression is fixed #1785
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1785 +/- ##
==========================================
+ Coverage 41.57% 41.64% +0.07%
==========================================
Files 535 541 +6
Lines 23518 23701 +183
Branches 6938 7817 +879
==========================================
+ Hits 9778 9871 +93
+ Misses 13699 13190 -509
- Partials 41 640 +599 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We've noticed that after somebody fixes a suppressed lint problem, the build breaks until the suppressions file is pruned. Jaycie and others have found that this was annoying, as it means the build effectively discourages fixing lint problems. We've decided the best way forward will be a precommit hook that automatically prunes suppressions for fixed problems. Until we build that, this change allows the build to pass even when the suppressions file is out of date.
This reverts commit d5470f3.
barna-isaac
changed the title
|
We've noticed that after somebody fixes a suppressed lint problem, the build breaks until the suppressions file is pruned. @jacbn and others have found that this was annoying, as it means the build effectively discourages fixing lint problems. We've decided the best way forward will be a precommit hook that automatically prunes suppressions for fixed problems. Until we build that, this change allows the build to pass even when the suppressions file is out of date. |
This reverts commit 45c8a36, as there would be a merge conflict.
|
Reverted prune suppressions commit to avoid merge conflict. |
No description provided.